[Openmp-commits] [PATCH] D51303: [OpenMP][Fix] Conditional compilation leaves variables unused

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Aug 27 09:42:08 PDT 2018


Hahnfeld requested changes to this revision.
Hahnfeld added a reviewer: protze.joachim.
Hahnfeld added a comment.
This revision now requires changes to proceed.

The call must not be put into conditional compilation. As discussed in https://reviews.llvm.org/D50774 there are two options:

1. Guard the variable definition and assignment (the first line) by preprocessor guards.
2. Add a `(void) *_status;` to silence the warning.

I think the latter one is used many times in Clang, so I'd favor that.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51303





More information about the Openmp-commits mailing list