[Openmp-commits] [PATCH] D51226: [OpenMP][libomptarget] rework of fatal error reporting

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

LGTM. One very minor comment inline, I leave it up to you whether you want to make that change - it's more important that we unbreak the build.



================
Comment at: libomptarget/src/private.h:51
+  do {                                                                \
+    fprintf(stderr, "Libomptarget fatal error %d: %s\n", _num, _str); \
+    exit(1);                                                          \
----------------
You could probably put `_str` directly into the string as in `FATAL_MESSAGE`, but I don't think this makes a difference.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51226