[Openmp-commits] [PATCH] D51226: [OpenMP][libomptarget] rework of fatal error reporting

Alexandre Eichenberger via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Aug 24 10:49:25 PDT 2018


AlexEichenberger added a comment.

In https://reviews.llvm.org/D51226#1212685, @Hahnfeld wrote:

> I don't understand this: In the last review you said that we need the complicated `FatalMessage` and now you are reverting that?!?


I am reimplementing this because it needs an include that may be fragile on some platforms (https://reviews.llvm.org/D51219)

using the #def, I can avoid getting a lock as the whole printing is done in one fprintf


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51226





More information about the Openmp-commits mailing list