[Openmp-commits] [PATCH] D46185: [OpenMP] Allow nvptx sm_30 to be used as an offloading device

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D46185#1081362, @guansong wrote:

> In https://reviews.llvm.org/D46185#1081124, @Hahnfeld wrote:
>
> > Anyway, why do you want to support `sm_30`? Is there a particular hardware that you want to support? Why does AMD care?!?
>
>
> I will double check with Greg on the way atomicCAS used in the code. For the last question here. We have sm_30 machine for testing. Besides, from my perspective, I care the overall implementation of openmp, particularly the offloading part, not necessarily amdgcn code only :)


Okay, then the question is: Will the implementation get better if it supports 6 years old hardware with yet another code path that only few people care about and that will get less testing? From intuition I doubt that because extra code for old hardware won't get much support and attention by definition.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D46185