[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: runtime/src/kmp_tasking.cpp:569
+                                          void *return_address) {
+  return __kmpc_omp_task_begin_if0_template<true>(loc_ref, gtid, task,
+                                                 frame_address, return_address);
----------------
Return type is void.


================
Comment at: runtime/src/kmp_tasking.cpp:591
+#endif
+  return __kmpc_omp_task_begin_if0_template<false>(loc_ref, gtid, task,
+                                                  NULL, NULL);
----------------
Return type is void.


================
Comment at: runtime/src/kmp_tasking.cpp:1707
+    OMPT_STORE_RETURN_ADDRESS(gtid);
+    return __kmpc_omp_taskwait_template<true>(loc_ref, gtid, OMPT_GET_FRAME_ADDRESS(1),
+                                   OMPT_LOAD_RETURN_ADDRESS(gtid));
----------------
I think the intention here was to call the outlined function __kmpc_omp_taskwait_ompt.


https://reviews.llvm.org/D38185