[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim marked 19 inline comments as done.
protze.joachim added inline comments.


================
Comment at: runtime/src/kmp_tasking.cpp:1700-1705
+kmp_int32 __kmpc_omp_taskwait(ident_t *loc_ref, kmp_int32 gtid) {
+#if OMPT_SUPPORT && OMPT_OPTIONAL
+  if (UNLIKELY(ompt_enabled.enabled)) {
+    return __ompt_enabled_taskwait(loc_ref, gtid, OMPT_GET_FRAME_ADDRESS(1),
+                                   OMPT_GET_RETURN_ADDRESS(0));
+  }
----------------
Hahnfeld wrote:
> Puh, that's ugly. Is this needed for performance reasons?
The event for this function was identified to incur serious overhead for benchmarks like nqueens/kdtree/fibonacci with if(0) cut-off. Hansang provided this implementation as a performance fix.


https://reviews.llvm.org/D38185