[Openmp-commits] [PATCH] D40171: Fix for OMP doacross implementation on 32-bit platforms

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

Do we need all `volatile` casts that force the different code paths for 32 and 64 bit? In my experiments on Power it worked without them...



================
Comment at: runtime/src/kmp_csupport.cpp:3809
+  // Treat pointer as volatile integer (value 0 or 1) until memory is allocated.
+  flags = (kmp_uint32 *)KMP_COMPARE_AND_STORE_RET32(
+      (volatile kmp_int32 *)&sh_buf->doacross_flags, NULL, 1);
----------------
Should we introduce `KMP_COMPARE_AND_STORE_RETPTR` for this?


Repository:
  rL LLVM

https://reviews.llvm.org/D40171