[Openmp-commits] [PATCH] D31071: GOMP compatibility: add missing OMP4.0 taskdeps handling code

[Paul Osmialowski via Phabricator via Openmp-commits]

pawosm01 added a comment.

In https://reviews.llvm.org/D31071#708701, @jcownie wrote:

> > Setting all flags in both branches seemed to me as better expressing my intents, but I can change it if you insist.
>
> I am not going to insist. I just find it odd to have a duplicate line of code, and the fact that it is the same in both if branches made me suspicious that there was bug lurking there. So, personally,  I would find code like this clearer.
>
>   dep_list[i].len = 0U;
>   dep_list[i].flags.in = 1;
>   dep_list[i].flags.out = i<nout;
>   
>   


Yep, that looks better.


Repository:
  rL LLVM

https://reviews.llvm.org/D31071