[Openmp-commits] [PATCH] D31071: GOMP compatibility: add missing OMP4.0 taskdeps handling code

[Paul Osmialowski via Phabricator via Openmp-commits]

pawosm01 added a comment.

In https://reviews.llvm.org/D31071#708667, @jcownie wrote:

> Is "dep_list[i].flags.in = 1;" really supposed to be set in both of the if cases (lines 980 and 983)?
>  If so, can't we lift that out of the if?


Yes and maybe. It must me set to 1 for both due to  ```KMP_DEBUG_ASSERT(dep->flags.in);``` checked for each task dependency processed by __kmp_process_deps() in kmp_taskdeps.cpp. Setting all flags in both branches seemed to me as better expressing my intents, but I can change it if you insist.


Repository:
  rL LLVM

https://reviews.llvm.org/D31071