[Openmp-commits] [PATCH] D31055: [OpenMP] libomptarget: Disable on MacOS X

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: CMakeLists.txt:10
+# there is no point in trying to compile libomptarget on other OSes.
+if (NOT (WIN32 OR ${CMAKE_SYSTEM_NAME} MATCHES "Darwin"))
   add_subdirectory(libomptarget)
----------------
Hahnfeld wrote:
> Should we do this the other way around and say `CMAKE_SYSTEM_NAME MATCHES "Linux"`?
Technically, the plugins' CMakeLists.txt's require that the build system is Linux, however there is no reason I'm aware of why they cannot be built on any Unix system, as long as it supports the ELF executable format (e.g. FreeBSD). So maybe the best choice is to leave the condition above as-is (!win32 && !darwin) and change the plugins' CMakeLists to support general Unices. Any thoughts?


Repository:
  rL LLVM

https://reviews.llvm.org/D31055