[Openmp-commits] [PATCH] D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

[Guansong Zhang via Phabricator via Openmp-commits]

guansong added a comment.

In https://reviews.llvm.org/D33227#775415, @grokos wrote:

> In https://reviews.llvm.org/D33227#775337, @guansong wrote:
>
> > Just to share what I have locally. I have OFFLOAD_DEBUG=1 for the plugin side debug messages, and DEVICE_DEBUG=1 for the deviceRTL side messages.
>
>
> So are you suggesting that each plugin has its own env variable to turn debug output on/off?


No. I am thinking one should be OK for all plugins.

For LIBOMPTARGET_DEBUG, will it control the device side of the debug message later on?

You call it "target", that gives me the impression it will. But maybe that is not the case. And LIBOMPOFFLOAD_DEBUG may be a better name.

In my scenario, I do have two flags, one is for the host (actually the code is almost identical to yours), and one for the device.

The device side of the variable may need to be specific to each device. The one I have can work for GPU, but it may not work well for PHI. As in this case the device and host will share the same openmp runtime mechanism?


https://reviews.llvm.org/D33227