[Openmp-commits] D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

[Hahnfeld, Jonas via Openmp-commits]

I think KMP_ has a historical reason that's explained with origin of the 
OpenMP runtime. I don't think this fits for libomptarget, so I'd prefer 
LIBOMPTARGET_xxx.

Jonas

-----Original Message-----
From: Wilmarth, Terry L [mailto:terry.l.wilmarth at intel.com]
Sent: Thursday, June 1, 2017 6:12 PM
To: Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>; 
reviews+D33227+public+e370644a3ef9e170 at reviews.llvm.org; Dmitriev, Serguei N 
<serguei.n.dmitriev at intel.com>; grokos at us.ibm.com; Hahnfeld, Jonas 
<Hahnfeld at itc.rwth-aachen.de>
Cc: openmp-commits at lists.llvm.org; mgorny at gentoo.org; lildmh at gmail.com; 
acjacob at us.ibm.com; guansong.zhang at amd.com
Subject: RE: D33227: [OpenMP] libomptarget: move debugging dumps under control 
of environment variable OMP_TARGET_DEBUG

KMP_ ?  :)

-----Original Message-----
From: Narayanaswamy, Ravi
Sent: Thursday, June 01, 2017 9:55 AM
To: reviews+D33227+public+e370644a3ef9e170 at reviews.llvm.org; Dmitriev, Serguei 
N <serguei.n.dmitriev at intel.com>; grokos at us.ibm.com; 
Hahnfeld at itc.rwth-aachen.de; Wilmarth, Terry L <terry.l.wilmarth at intel.com>
Cc: openmp-commits at lists.llvm.org; mgorny at gentoo.org; lildmh at gmail.com; 
acjacob at us.ibm.com; guansong.zhang at amd.com
Subject: RE: D33227: [OpenMP] libomptarget: move debugging dumps under control 
of environment variable OMP_TARGET_DEBUG

Terry has brought up a good point.  We should reserve "OMP_" prefix for OpenMP 
lang defined environments We should rename OMP_TARGET_OFFLOAD and 
OMP_TARGET_DEBUG.
We currently have a proposal from Terry : LIBOMPTARGET_xxx Any other proposal, 
we can if necessary finalize in our bi-weekly meeting.


-----Original Message-----
From: Terry Wilmarth via Phabricator [mailto:reviews at reviews.llvm.org]
Sent: Wednesday, May 31, 2017 2:37 PM
To: Dmitriev, Serguei N <serguei.n.dmitriev at intel.com>; grokos at us.ibm.com; 
Hahnfeld at itc.rwth-aachen.de; Wilmarth, Terry L <terry.l.wilmarth at intel.com>; 
Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>
Cc: openmp-commits at lists.llvm.org; mgorny at gentoo.org; lildmh at gmail.com; 
acjacob at us.ibm.com; guansong.zhang at amd.com
Subject: [PATCH] D33227: [OpenMP] libomptarget: move debugging dumps under 
control of environment variable OMP_TARGET_DEBUG

tlwilmar added a comment.

Hmmm... that's disturbing.

The policy for libomp is, if it's in the spec, it starts with OMP_, and if 
it's just in our implementation, it starts with KMP_.
I guess this is not true for libomptarget.   I'd like to get Ravi's opinion on 
this, so don't make a change yet.


https://reviews.llvm.org/D33227



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20170602/09cf3745/attachment.bin>