[Openmp-commits] [PATCH] D35719: [CMake] Disable building libomptarget and add CMake switch

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld marked 3 inline comments as done.
Hahnfeld added inline comments.


================
Comment at: CMakeLists.txt:8
+
+set(ENABLE_LIBOMPTARGET ON)
 # Currently libomptarget cannot be compiled on Windows or MacOS X.
----------------
hans wrote:
> Hahnfeld wrote:
> > hans wrote:
> > > Since the tests fail by default, I think it should be disabled in the build by default.
> > > 
> > > trunk should always be in a working state.
> > Well, it's broken since January so nobody cared enough. @gtbercea, what do you think?
> Most people don't check out or build the openmp repo, and your buildbot doesn't run the tests -- which is another reason the code shouldn't be built by default.
Updated the patch. I'll let it sit for two days or so to give the others time to respond.


https://reviews.llvm.org/D35719