[Openmp-commits] [PATCH] D35417: Second part of -Wcast-qual option enabling for OpenMP RTL code

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 14 08:15:41 PDT 2017


AndreyChurbanov created this revision.
AndreyChurbanov added a project: OpenMP.

Previous patch r307020 has broken Windows build, mostly because changes were done in places of Linux compilers warnings without paying attention to Windows specific code.

This patch adds more consistency and also fixes the Windows build of the library.

- all atomics now accept volatile pointer parameter; this allows to simplify a lot of type conversions.
- NULL pointer value changed to nullptr in sensible places.
- all 32-bit and 64-bit AND/OR atomics accept unsigned parameters (not only Unix specific that initial patch did).

Tried to build the library on Windows, and on Linux.


Repository:
  rL LLVM

https://reviews.llvm.org/D35417

Files:
  runtime/src/kmp_affinity.cpp
  runtime/src/kmp_affinity.h
  runtime/src/kmp_alloc.cpp
  runtime/src/kmp_barrier.cpp
  runtime/src/kmp_csupport.cpp
  runtime/src/kmp_dispatch.cpp
  runtime/src/kmp_lock.cpp
  runtime/src/kmp_os.h
  runtime/src/kmp_runtime.cpp
  runtime/src/kmp_settings.cpp
  runtime/src/kmp_tasking.cpp
  runtime/src/kmp_taskq.cpp
  runtime/src/kmp_wait_release.h
  runtime/src/thirdparty/ittnotify/ittnotify_config.h
  runtime/src/z_Linux_util.cpp
  runtime/src/z_Windows_NT-586_util.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35417.106633.patch
Type: text/x-patch
Size: 50020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20170714/ca25e76b/attachment-0001.bin>


More information about the Openmp-commits mailing list