[Openmp-commits] [PATCH] D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG

Terry Wilmarth via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jul 5 11:23:37 PDT 2017


tlwilmar added a comment.

In https://reviews.llvm.org/D33227#792489, @sdmitriev wrote:

> In https://reviews.llvm.org/D33227#769266, @tlwilmar wrote:
>
> > I don't think the environment variable should be named "OMP_TARGET_DEBUG" as that would suggest it is something coming from the OpenMP specification, which I don't believe it is.  I'd suggest just keeping the LIBOMPTARGET_DEBUG name at all levels.
>
>
> Terry, I have changed the environment variable name as you suggested. Do you have more comments for this patch?


No more comments.  Thanks!


https://reviews.llvm.org/D33227





More information about the Openmp-commits mailing list