[Openmp-commits] [openmp] r292348 - Fix small memory leak regarding __kmp_nested_proc_bind

[Churbanov, Andrey via Openmp-commits]

I support merging this one.

- Andrey

-----Original Message-----
From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf Of Hans Wennborg
Sent: Thursday, January 19, 2017 9:40 PM
To: Hahnfeld, Jonas <Hahnfeld at itc.rwth-aachen.de>
Cc: Peyton, Jonathan L <jonathan.l.peyton at intel.com>; openmp-commits at lists.llvm.org; Churbanov, Andrey <Andrey.Churbanov at intel.com>
Subject: Re: [Openmp-commits] [openmp] r292348 - Fix small memory leak regarding __kmp_nested_proc_bind

Sounds reasonable to me. Jonathan, what do you think, should we merge this?

On Wed, Jan 18, 2017 at 12:57 AM, Hahnfeld, Jonas <Hahnfeld at itc.rwth-aachen.de> wrote:
> Is this one a candidate for release_40?
>
> Thanks,
> Jonas
>
>> -----Original Message-----
>> From: Openmp-commits [mailto:openmp-commits-bounces at lists.llvm.org]
>> On Behalf Of Jonathan Peyton via Openmp-commits
>> Sent: Wednesday, January 18, 2017 7:40 AM
>> To: openmp-commits at lists.llvm.org
>> Subject: [Openmp-commits] [openmp] r292348 - Fix small memory leak 
>> regarding __kmp_nested_proc_bind
>>
>> Author: jlpeyton
>> Date: Wed Jan 18 00:40:19 2017
>> New Revision: 292348
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=292348&view=rev
>> Log:
>> Fix small memory leak regarding __kmp_nested_proc_bind
>>
>> There is no corresponding free() for this expandable array.  The 
>> logic is added in __kmp_cleanup() next to the freeing of __kmp_nested_nth.
>>
>> Modified:
>>     openmp/trunk/runtime/src/kmp_runtime.cpp
>>
>> Modified: openmp/trunk/runtime/src/kmp_runtime.cpp
>> URL: http://llvm.org/viewvc/llvm-
>> project/openmp/trunk/runtime/src/kmp_runtime.cpp?rev=292348&r1=2923
>> 47&r2=292348&view=diff
>> ==========================================================
>> ====================
>> --- openmp/trunk/runtime/src/kmp_runtime.cpp (original)
>> +++ openmp/trunk/runtime/src/kmp_runtime.cpp Wed Jan 18 00:40:19 2017
>> @@ -7293,6 +7293,10 @@ __kmp_cleanup( void )
>>      __kmp_nested_nth.nth = NULL;
>>      __kmp_nested_nth.size = 0;
>>      __kmp_nested_nth.used = 0;
>> +    KMP_INTERNAL_FREE( __kmp_nested_proc_bind.bind_types );
>> +    __kmp_nested_proc_bind.bind_types = NULL;
>> +    __kmp_nested_proc_bind.size = 0;
>> +    __kmp_nested_proc_bind.used = 0;
>>
>>      __kmp_i18n_catclose();
>>
>>
>>
>> _______________________________________________
>> Openmp-commits mailing list
>> Openmp-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits

--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.