[Openmp-commits] [PATCH] D41508: [OMPT] Build runtime with OMPT support by default
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Fri Dec 22 02:24:22 PST 2017
Hahnfeld requested changes to this revision.
Hahnfeld edited reviewers, added: pawosm01, hfinkel; removed: pawelo.
Hahnfeld added a comment.
This revision now requires changes to proceed.
I don't think we should enable this unconditionally, only for the architectures where we tested and are sure that the tests will pass: x86, x86_64, ppc64, aarch64 on Linux, macOS if we want to. With the current change we will get into trouble at least on MIPS(64).
Comment at: runtime/CMakeLists.txt:305-309
+ set(LIBOMP_OMPT_SUPPORT TRUE CACHE BOOL
+ set(LIBOMP_OMPT_SUPPORT FALSE CACHE BOOL
I think it would be better to only have one definition of cache variables:
set(LIBOMP_OMPT_SUPPORT TRUE CACHE BOOL
"Enable support for OMPT?")
More information about the Openmp-commits