[Openmp-commits] [PATCH] D41171: [OMPT] Handle null pointer in set_callback to improve performance
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Thu Dec 21 07:46:01 PST 2017
Hahnfeld added inline comments.
Comment at: runtime/test/ompt/misc/unset_callback.c:8
+ int x = 0;
+ #pragma omp parallel num_threads(1)
> Hahnfeld wrote:
> > Not needed.
> Some OpenMP activity is needed to initialize the OpenMP runtime, let the runtime call ompt_start_tool and ompt_inittialize, so that ompt_set_callback is set to non-NULL.
I think Phabricator mangled my comment: I originally meant the unused variable `x` that Simon removed meanwhile. I agree that we need the first parallel region.
More information about the Openmp-commits