[Openmp-commits] [PATCH] D41181: [OMPT] Fix return address handling in a few GOMP interface methods

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Dec 20 01:09:01 PST 2017


Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

LG but please describe which test cases are fixed by this change (and possibly why it is needed). If no test case has been failing before, this is a sign that we need a new one!



================
Comment at: runtime/src/kmp_gsupport.cpp:1212
+#if OMPT_SUPPORT
+  OMPT_STORE_RETURN_ADDRESS(gtid);
+#endif
----------------
Please add a comment why we need to do this again. I think that the return address is cleared at some point in the function calls above?


https://reviews.llvm.org/D41181





More information about the Openmp-commits mailing list