[Openmp-commits] [PATCH] D41000: AArch64: fix cpuinfo issues

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Dec 9 16:34:34 PST 2017


Hahnfeld added inline comments.


================
Comment at: runtime/src/kmp_affinity.cpp:2032
+#if KMP_ARCH_AARCH64
+          num_avail++;
+#else
----------------
Multiple questions here, could you maybe add some comments with the answers?
1. This can only happen for the "old" format? And we can't diagnose duplicate field errors in the new format because we just assume that we are seeing the old format, right?
2. The "old" format doesn't have other information than the "processor <id>" specified? Because the code further down relies on `num_avail` pointing to the current entry.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41000





More information about the Openmp-commits mailing list