[Openmp-commits] [PATCH] D40920: Unify build documentation and convert to reStructuredText

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: README.rst:256-258
+**LIBOMPTARGET_NVPTX_ENABLE_BCLIB** = ``OFF|ON``
+  Enable CUDA LLVM bitcode offloading device RTL. This is used for link time
+  optimization of the OpenMP runtime and application code.
----------------
grokos wrote:
> We had an internal discussion about it. Do we have consensus that we'll support bclib?
For now, I've only copied what has been in `libomptarget/Build_With_CMake.txt`. To be honest I think we should remove this paragraph entirely because the NVPTX runtime hasn't been committed yet so that we don't confuse the users.


================
Comment at: README.rst:317-318
+
+- Have CMake find the C/C++ compiler, and specify additional flags for the C
+  compiler, preprocessor, and C++ compiler.
+
----------------
grokos wrote:
> Remove commas before "and" (2 places).
Some of the comas are intentional to be consistent with the rest of LLVM's documentation: https://en.wikipedia.org/wiki/Serial_comma


https://reviews.llvm.org/D40920