[Openmp-commits] [PATCH] D26182: Fixed problem introduced by part of https://reviews.llvm.org/D21196.

Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 1 09:28:39 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL285703: Fixed problem introduced by part of https://reviews.llvm.org/D21196. (authored by achurbanov).

Changed prior to commit:
  https://reviews.llvm.org/D26182?vs=76540&id=76578#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D26182

Files:
  openmp/trunk/runtime/src/kmp_tasking.c


Index: openmp/trunk/runtime/src/kmp_tasking.c
===================================================================
--- openmp/trunk/runtime/src/kmp_tasking.c
+++ openmp/trunk/runtime/src/kmp_tasking.c
@@ -1801,8 +1801,8 @@
             parent = parent->td_parent;  // check generation up to the level of the current task
             KMP_DEBUG_ASSERT(parent != NULL);
         }
-        if ( parent != current && (taskdata->td_flags.tiedness == TASK_TIED) ) { // untied is always allowed to be stolen
-            // If the tail task is not a child, then no other childs can appear in the deque (?).
+        if ( parent != current ) {
+            // If the tail task is not a descendant of the current task then do not steal it.
             __kmp_release_bootstrap_lock( & victim_td -> td.td_deque_lock );
             KA_TRACE(10, ("__kmp_steal_task(exit #2): T#%d could not steal from T#%d: task_team=%p "
                           "ntasks=%d head=%u tail=%u\n",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26182.76578.patch
Type: text/x-patch
Size: 969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20161101/3acb4bae/attachment.bin>


More information about the Openmp-commits mailing list