[Openmp-commits] [PATCH] D16525: Add CMAKE variable to enable creation of static OpenMP libraries instead of dynamic ones

[Jonathan Peyton via Openmp-commits]

jlpeyton added a comment.

Add the new variable to Build_With_CMake.txt with note that it isn't available on Windows.


================
Comment at: runtime/CMakeLists.txt:280-283
@@ -279,2 +279,6 @@
 
+# Default to shared library
+set(LIBOMP_SHARED_LIBRARY TRUE CACHE BOOL
+  "Create shared library?")
+
 # OMPT-support
----------------
This is a minor nit, but can this be renamed to LIBOMP_STATIC_LIBRARY which is FALSE by default.  Setting a feature to true to enable the feature seems a little more intuitive for the user.  Also, make a note in the comment that this feature isn't available on Windows, and put below this:

```
 if(WIN32 AND LIBOMP_STATIC_LIBRARY)
   libomp_error_say("Static libraries requested but not available on Windows")
 endif()
```


Repository:
  rL LLVM

http://reviews.llvm.org/D16525