[Openmp-commits] [PATCH] D16714: [OMPT] Fix wrong parent_task_id in serialized parallel_begin with GCC

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Mon Feb 29 00:21:31 PST 2016

Hahnfeld added a comment.

In http://reviews.llvm.org/D16714#362790, @omalyshe wrote:

> Is it OK that __ompt_parallel_id_new() is called several times for one region? First in line 393 and then inside __kmp_serialized_parallel() it can be called once or twice.

While this isn't good from a performance perspective I think this won't hurt for correctness: It will skip some ids but contiguous ids aren't required by the standard.
On the other hand I don't know if this may be required in some cases, I don't always fully understand the code paths in the runtime library...


More information about the Openmp-commits mailing list