[Openmp-commits] [PATCH] D27647: Fix arguments of trace output in __kmp_push_stack

[Victor Campos via Phabricator via Openmp-commits]

vhscampos updated this revision to Diff 81125.
vhscampos added a comment.

Moved trace call inside the critical section.


https://reviews.llvm.org/D27647

Files:
  runtime/src/kmp_tasking.c


Index: runtime/src/kmp_tasking.c
===================================================================
--- runtime/src/kmp_tasking.c
+++ runtime/src/kmp_tasking.c
@@ -336,12 +336,12 @@
     thread_data -> td.td_deque_tail = ( thread_data -> td.td_deque_tail + 1 ) & TASK_DEQUE_MASK(thread_data->td);
     TCW_4(thread_data -> td.td_deque_ntasks, TCR_4(thread_data -> td.td_deque_ntasks) + 1);             // Adjust task count
 
-    __kmp_release_bootstrap_lock( & thread_data -> td.td_deque_lock );
-
     KA_TRACE(20, ("__kmp_push_task: T#%d returning TASK_SUCCESSFULLY_PUSHED: "
-                  "task=%p ntasks=%d head=%u tail=%u\n",
-                  gtid, taskdata, thread_data->td.td_deque_ntasks,
-                  thread_data->td.td_deque_tail, thread_data->td.td_deque_head) );
+          "task=%p ntasks=%d head=%u tail=%u\n",
+          gtid, taskdata, thread_data->td.td_deque_ntasks,
+          thread_data->td.td_deque_head, thread_data->td.td_deque_tail) );
+
+    __kmp_release_bootstrap_lock( & thread_data -> td.td_deque_lock );
 
     return TASK_SUCCESSFULLY_PUSHED;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27647.81125.patch
Type: text/x-patch
Size: 1093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20161212/50997083/attachment.bin>