[Openmp-commits] [PATCH] D23307: [OMPT] Reset task exit frame when execution is finished

Jonathan Peyton via Openmp-commits openmp-commits at lists.llvm.org
Wed Aug 17 13:34:30 PDT 2016


jlpeyton added inline comments.

================
Comment at: runtime/src/kmp_runtime.c:1549
@@ +1548,3 @@
+#if OMPT_SUPPORT
+                *exit_runtime_p=0;
+#endif
----------------
Use NULL instead.   And can this be moved down to the `#if OMPT_SUPPORT` section just 4 to 5 lines below?

================
Comment at: runtime/src/kmp_runtime.c:1749
@@ +1748,3 @@
+#if OMPT_SUPPORT
+                *exit_runtime_p=0;
+#endif
----------------
Same here.

================
Comment at: runtime/src/kmp_runtime.c:1858
@@ +1857,3 @@
+#if OMPT_SUPPORT
+                *exit_runtime_p=0;
+#endif
----------------
Same here.

================
Comment at: runtime/src/kmp_runtime.c:6836
@@ +6835,3 @@
+#if OMPT_SUPPORT
+                *exit_runtime_p=0;
+#endif
----------------
Use NULL instead.


https://reviews.llvm.org/D23307





More information about the Openmp-commits mailing list