[Openmp-commits] [PATCH] D23115: __kmp_free_task: Fix for serial explicit tasks producing proxy tasks

[Jonas Hahnfeld via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D23115#504652, @hfinkel wrote:

> In https://reviews.llvm.org/D23115#504641, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D23115#504638, @hfinkel wrote:
> >
> > > Please add your example as a regression test case.
> >
> >
> > Hmm, that will be tricky: Currently only the Intel Compiler will generate proxy tasks for `target nowait`...
>
>
> In general, I'd still add the test (just with a comment that it had failed using the Intel compiler). I presume that the test suite runs with the Intel compiler too. Since this uses the target directive, however, I'm not sure it will run with Clang currently, so we might need to wait.


Hmm, I don't quite see much sense in a test that would not fail with the compilers the tests are most commonly (and automatically) run with.
Maybe we could reuse the idea of `tasking/kmp_taskloop.c` where the compiler generated code is manually emitted...


https://reviews.llvm.org/D23115