[Openmp-commits] [PATCH] D14027: [OMPT] Windows Support for OMPT

[John Mellor-Crummey via Openmp-commits]

jmellorcrummey added a comment.

I have one more minor comment

Lines 104 and 105 of ompt-general.c should be reversed.

_OMP_EXTERN 
#if OMPT_HAVE_WEAK_ATTRIBUTE

should be

#if OMPT_HAVE_WEAK_ATTRIBUTE
_OMP_EXTERN

because the _OMP_EXTERN does not apply to the #elseif case.

Besides that, everything now looks good to me.


Repository:
  rL LLVM

http://reviews.llvm.org/D14027