[Openmp-commits] [PATCH] D14055: [OPENMP] Add dependency to clang/clang-headers etc. for in-tree build of libomp.
Alexey Bataev via Openmp-commits
openmp-commits at lists.llvm.org
Wed Oct 28 10:58:11 PDT 2015
ABataev marked 2 inline comments as done.
Comment at: runtime/test/CMakeLists.txt:57
@@ -56,3 +56,3 @@
- set(LIBOMP_TEST_OPENMP_FLAG -fopenmp=libomp)
+ set(LIBOMP_TEST_OPENMP_FLAG -fopenmp)
# Use add_lit_testsuite() from LLVM CMake.
> This seems like it should be landed separately, and after your patch to Clang lands?
Ok, will revert it back for now
Comment at: runtime/test/api/omp_get_wtime.c:12
@@ -11,3 +11,3 @@
- double wait_time = 0.25;
+ double wait_time = 1.0;
start = 0;
> The commit log doesn't make it clear why this has changed?
This is required to fix possible issues with parallel testing of libomp. This test is quite sensitive to possible time diffs, so it's better to take a little bit more time to check that omp_get_wtime() function works correctly
More information about the Openmp-commits