[Openmp-commits] [PATCH] D14027: [OMPT] Windows Support for OMPT
John Mellor-Crummey via Openmp-commits
openmp-commits at lists.llvm.org
Fri Oct 23 14:53:04 PDT 2015
jmellorcrummey added a comment.
I was wrong. I had one more thing to say :-).
Changing strcasecmp for argument matching to __kmp_str_match is another change that binds the ompt-general.c implementation to the Intel runtime.
I would prefer adding a layer of abstraction to this if you want to use __kmp_str_match. I recommend that ompt-specific.h have the following line added
#define OMPT_STR_MATCH(haystack, needle) __kmp_str_match(haystack, 0, needle)
and then in ompt-general.c, include the following line
#define OMPT_STR_MATCH(haystack, needle) (!strcasecmp(haystack, needle))
More information about the Openmp-commits