[Openmp-commits] [PATCH] D14027: [OMPT] Windows Support for OMPT
John Mellor-Crummey via Openmp-commits
openmp-commits at lists.llvm.org
Fri Oct 23 14:21:08 PDT 2015
jmellorcrummey added a comment.
Two more things:
First, I made some name changes in the midst of writing my prior comment. I didn't change one occurrence. The corrected #define for the prior comment should be
#define ompt_tool ompt_tool_windows
Second, I note that the implementation
will fail with an undefined symbol for ompt_tool if neither KMP_HAVE_WEAK_ATTRIBUTE or KMP_HAVE_PSAPI are defined. Should there be an #else case with a #error that says that either weak symbols or libpsapi are required.
More information about the Openmp-commits