[Openmp-commits] [PATCH] D13689: Add OMPT events for API locking
Tim Cramer via Openmp-commits
openmp-commits at lists.llvm.org
Tue Oct 13 09:46:30 PDT 2015
tcramer added a comment.
In http://reviews.llvm.org/D13689#265984, @jmellorcrummey wrote:
> In reading this patch over again, I realized that you implemented the OMPT TR2 lock initialization callback rather than the OMPT working draft, which also passes a lock hint and a lock type to the init callback. The OMPT implementation in LLVM OpenMP is evolving with the current version of the OMPT draft. There are features already in the code that aren't in OMPT TR2. Fort that reason, I think you should add the lock hint and lock type parameters.
Thats true. However, the OpenMP runtime library routine "omp_init_lock_with_hint" seems not to be implemented at the moment, because it will come with OpenMP 4.5 (aka 4.1). Thus, I can only pass a hard-coded 0 (which will be omp_lock_hint_none) as hint at the moment.
I agree that the lock type is already implementable, but since it is a change in OMPT infrastructure itself, it should be a separated patch anyway.
I would propose to use the old signature for now and change it as soon as we have the new locking library routine. Does that sound reasonable?
More information about the Openmp-commits