[Openmp-commits] [PATCH] D14383: Add OMPT events for the OpenMP taskwait construct.

John Mellor-Crummey via Openmp-commits openmp-commits at lists.llvm.org
Fri Nov 6 13:33:32 PST 2015


jmellorcrummey added a comment.

It appears that no context is available for the diffs. Without the context, I can't tell whether the additions are appropriate or not. The callbacks are intended to monitor the beginning and end of an episode of waiting. There is no evidence of the waiting in the diffs provided without context.

Please prepare the diffs using "git diff -U999999 other-branch" and update the diffs for this patch.


http://reviews.llvm.org/D14383





More information about the Openmp-commits mailing list