[Openmp-commits] [PATCH] D12211: [OpenMP] [CMake] Removing expand-vars.pl in favor of CMake's configure_file()

[Jonathan Peyton via Openmp-commits]

jlpeyton updated this revision to Diff 32958.
jlpeyton added a comment.

Updating diff to address Jonas's concerns.

> Couldn't this be replaced with #include "kmp_config.h" ...


Replaced.

> ... and this be #if KMP_DEBUG?


Replaced.

> The README still says LLVM* OpenMP*. Was this change intended?


Not intended, changed it to LLVM* OpenMP* again.

Thanks Jonas for pointing these out.

Also, I removed a commented line of code (line 155) from runtime/src/CMakeLists.txt
 #set_source_files_properties(libomp.rc PROPERTIES EV_COMPILE_DEFINITIONS "-D KMP_FILE=${LIBOMP_LIB_FILE}" GENERATED TRUE)


Repository:
  rL LLVM

http://reviews.llvm.org/D12211

Files:
  runtime/CMakeLists.txt
  runtime/cmake/LibompDefinitions.cmake
  runtime/cmake/LibompHandleFlags.cmake
  runtime/src/CMakeLists.txt
  runtime/src/include/30/omp.h.var
  runtime/src/include/30/omp_lib.f.var
  runtime/src/include/30/omp_lib.f90.var
  runtime/src/include/30/omp_lib.h.var
  runtime/src/include/40/omp.h.var
  runtime/src/include/40/omp_lib.f.var
  runtime/src/include/40/omp_lib.f90.var
  runtime/src/include/40/omp_lib.h.var
  runtime/src/include/41/omp.h.var
  runtime/src/include/41/omp_lib.f.var
  runtime/src/include/41/omp_lib.f90.var
  runtime/src/include/41/omp_lib.h.var
  runtime/src/kmp.h
  runtime/src/kmp_config.h.cmake
  runtime/src/kmp_itt.c
  runtime/src/kmp_os.h
  runtime/src/libomp.rc.var
  runtime/src/ompt-general.c
  runtime/src/thirdparty/ittnotify/ittnotify_static.c
  runtime/src/z_Linux_asm.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12211.32958.patch
Type: text/x-patch
Size: 38657 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20150824/d7f009a7/attachment-0001.bin>