[Openmp-commits] [PATCH] Modify runtime to call correct functions for OMPT

Olga Malysheva olga.malysheva at intel.com
Wed Apr 29 00:46:33 PDT 2015


================
Comment at: runtime/src/kmp_gsupport.c:343
@@ -277,3 +342,3 @@
 void
-__kmp_GOMP_fork_call(ident_t *loc, int gtid, microtask_t wrapper, int argc,...)
+__kmp_GOMP_fork_call(ident_t *loc, int gtid, void (*unwrapped_task)(void *), microtask_t wrapper, int argc,...)
 {
----------------
Hahnfeld wrote:
> omalyshe wrote:
> > Same here - let's put the additional argument under #if OMPT_SUPPORT
> While I'm ok with this change as well, this is a bit more tricky: __kmp_GOMP_fork_call is used inside macros (line #832 for example).
> I can't think of a better solution than defining a new macro that always takes the same arguments. The substitution will then depend on OMPT_SUPPORT...
> I think that doesn't fulfill any purpose. Other ideas?
> 
> While at it we could also change the new __kmp_GOMP_serialized_parallel (line #389)
OK, let's then remain this function as is and change only __kmp_fork_call() above. Thank you.

http://reviews.llvm.org/D8918

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the Openmp-commits mailing list