[Mlir-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

Mehdi Amini llvmlistbot at llvm.org
Fri May 17 09:45:01 PDT 2024


joker-eph wrote:

> It's a sed s/== None/is None/g - what is there to review?

On my I'm not asking for more reviews, this is why I commented that this should be **pushed** in multiple commits, I don't even need to see PRs.

Another thing also mentioned above was the problem of reverts.
If there is a problem in one of the project and this needs to be reverted, then it'll affect the other projects.
Also imagine that this lands, then someone refactor the python code in MLIR, and then LLDB finds an issue and tries to revert. They have now to figure out why is there a merge conflicts.

More commits in the history for unrelated projects does not seem like "noise" to me.

When I apply automated linter (clang-tidy), I will split these into 1 commit per file and push these.


https://github.com/llvm/llvm-project/pull/91857


More information about the Mlir-commits mailing list