[Mlir-commits] [mlir] [MLIR][Vector] Implement transferXXPermutationLowering as MaskableOpRewritePattern (PR #91987)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri May 17 09:30:47 PDT 2024


https://github.com/banach-space commented:

Hey Hugo, sorry for the delay with this.

Having read this again, I am realising that I forgot about `MemRef` semantics when implementing `MaskableOpRewritePattern` - thanks for fixing that! I think that it would be good to capture that with some additional comments - see my suggestions inline. It would also be good to updated the summary accordingly (something along the lines: 

> Updates MaskableOpRewritePattern so that it works correctly with MemRefs. 

Feel free to re-use and/or re-write.

https://github.com/llvm/llvm-project/pull/91987


More information about the Mlir-commits mailing list