[Mlir-commits] [mlir] [MLIR][SCF] Add an API to fuse consumer to a producer within scf loop (PR #88712)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> First of all, thanks for your contribution @Abhishek-Varma
> 
> Now, I am afraid I cannot subscribe to any large code changes to tiling transforms until #77874 is addressed to my satisfaction. I already gave a pass 6 months ago and another one 3 months ago when things were supposed to be addressed "in short order".
> 
> We're now past tech-debt reduction time:
> 
> 1. first let's address [[mlir][TilingInterface] Use `LoopLikeOpInterface` in tiling using SCF to unify tiling with `scf.for` and `scf.forall`. #77874](https://github.com/llvm/llvm-project/pull/77874),
> 2. then let's address the reuse as also pointed out by @ftynse
> 
> ```
> All of this code looks very similar to the scf.for case. Is it possible to hoist it out into a helper function, potentially with templates?
> 
> More generally, the entire 1,2,3,4, ... thing here could be a sequence of calls to appropriately named and documented functions. But not blocking on this one, only hoisting out long blocks of common code.
> ```
> 
> Thanks for helping move this forward!
> 
> At this time, more copy-pasta of code is unwelcome. Let's first reduce the duplication

@nicolasvasilache  I think it would good to unblock this (or at least decouple this from other concerns not directly related to this change). Like I said, this is not a duplication of anything existing and I am working on https://github.com/llvm/llvm-project/pull/91878 to remove the duplication.

I think we plan to land this next week. If you have any comments on the change itself, please let us know (and we can address post-commit as well)


https://github.com/llvm/llvm-project/pull/88712