[Mlir-commits] [mlir] [MLIR][LLVM] add dwarfAddressSpace to DIDerivedType (PR #92043)

William G Hatch llvmlistbot at llvm.org
Tue May 14 11:24:29 PDT 2024


willghatch wrote:

I've improved the testing, but when mentioning “round trip tests”, does that include anything other than `llvm-project/mlir/test/Target/LLVMIR/llvmir-debug.mlir` and `llvm-project/mlir/test/Target/LLVMIR/Import/debug-info.ll`?

I think using a signed integer to allow `-1` to represent nullopt is the best choice, so I've implemented and tested that.  I defined `#define MLIR_CAPI_DWARF_ADDRESS_SPACE_NULL -1` for the C API, please let me know if there is something better or more idiomatic.

https://github.com/llvm/llvm-project/pull/92043


More information about the Mlir-commits mailing list