[Mlir-commits] [clang] [clang-tools-extra] [flang] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon May 13 14:51:08 PDT 2024


klensy wrote:

> Were these found manually or using some automated tooling? Based on the Rust PR, it seems like these were found by just manually going through the results from a regex?

At first - yes, but later i noticed other error patterns and tried them iteratively; maybe some edit distance metrics can find more.

Ideally FileCheck should prefix commands with some tag to distinguish comments from filecheck annotations, like
`--command-tag=@` and use as `@CHECK: xxx`, `@MYCHECK-NEXT: yyy`, etc. Making typo\error in both prefix and command tag will be harder, i guess.

https://github.com/llvm/llvm-project/pull/91854


More information about the Mlir-commits mailing list