[Mlir-commits] [mlir] [mlir][vector] Split `TransposeOpLowering` into 2 patterns (PR #91935)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon May 13 12:03:22 PDT 2024


MaheshRavishankar wrote:

> > I think such a change causes failure on SPIR-V backend.
> 
> It shouldn't, this is merely moving code around.

IIRC this is now going to be generating a vector.shape_cast that isnt handled on SPIR-V backends, and this pattern is being added to a "generic vector lowering" pattern set. I'd suggest adding a "populateVectorTransposeLoweringForLLVMPatterns" and adding this to that path. I know the SPIR-V path isnt tested as well in MLIR, but the shape_cast isnt supported on SPIR-V path.

https://github.com/llvm/llvm-project/pull/91935


More information about the Mlir-commits mailing list