[Mlir-commits] [mlir] [mlir][linalg] Block pack matmul pass (PR #89782)

[Andrzej Warzyński]

banach-space wrote:

> Well, the PR is 2 weeks old and the last update was 2 days ago

This PR was marked as draft for most of that time, so I assumed that there was no rush and also that the PR wasn't ready for review.

>From LLVM docs https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted:

> If approval is received very quickly, a patch author may also elect to wait before committing (and this is certainly considered polite for non-trivial patches). Especially given the global nature of our community, this waiting time should be at least 24 hours.

There's many ways to read it. For a bigger change like this one, I really appreciate when people leave ~24hrs between the first approval and landing in-tree. Not a formal requirement nor policy, just a kind request.

Please don't take this the wrong way, I am OK with this change and support the effort. All my comments have been addressed.

https://github.com/llvm/llvm-project/pull/89782