[Mlir-commits] [mlir] [MLIR][Mem2Reg] Fix multi slot handling & move retry handling (PR #91464)

Tobias Gysi llvmlistbot at llvm.org
Wed May 8 11:38:57 PDT 2024


================
@@ -68,8 +68,12 @@ def PromotableAllocationOpInterface
         Hook triggered once the promotion of a slot is complete. This can
         also clean up the created default value if necessary.
         This will only be called for slots declared by this operation.
+
+        Must return a new promotable allocation op if this operation produced
+        multiple promotable slots, nullopt otherwise.
       }],
-      "void", "handlePromotionComplete",
+      "std::optional<::mlir::PromotableAllocationOpInterface>",
----------------
gysit wrote:

```suggestion
      "::std::optional<::mlir::PromotableAllocationOpInterface>",
```
nit:

https://github.com/llvm/llvm-project/pull/91464


More information about the Mlir-commits mailing list