[Mlir-commits] [mlir] Upstream polynomial.ntt and polynomial.intt (PR #90992)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Sat May 4 13:51:53 PDT 2024


================
@@ -123,9 +123,18 @@ def Polynomial_RingAttr : Polynomial_Attr<"Ring", "ring"> {
   let parameters = (ins
     "Type": $coefficientType,
     OptionalParameter<"IntegerAttr">: $coefficientModulus,
-    OptionalParameter<"PolynomialAttr">: $polynomialModulus
+    OptionalParameter<"PolynomialAttr">: $polynomialModulus,
+    OptionalParameter<"IntegerAttr">: $primitiveRoot
   );
 
+  let builders = [
+    AttrBuilder<
+        (ins "::mlir::Type":$coefficientTy,
+             "IntegerAttr":$coefficientModulusAttr,
+             "PolynomialAttr":$polynomialModulusAttr), [{
----------------
ftynse wrote:

Nit: let's me consistent about using the `::mlir::` prefix for types.

https://github.com/llvm/llvm-project/pull/90992


More information about the Mlir-commits mailing list