[Mlir-commits] [mlir] [mlir][emitc] Restrict types in EmitC (PR #88391)

Javier Setoain llvmlistbot at llvm.org
Thu May 2 10:48:42 PDT 2024


jsetoain wrote:

> We have had these discussions several times online and offline (already during upstreaming the dialect and the emitter), and the consensus was to make the dialect robust and keep the emitter simple. As @mgehre-amd mentioned, types that are not supported by the emitter can be represented with `!emitc.opaque<"mytype">`. Of course we are also happy to discuss if it makes sense to add support for further types to the dialect / emitter.

Just to clarify, does this mean that the right way to have a call to a function with unsupported types is to first `emit.cast` them into opaque types? What's breaking for us right now is an `emitc.opaque_call` to a function that takes bf16 vectors as parameters, and I'm trying to figure out what's the right thing to do here 😅 

https://github.com/llvm/llvm-project/pull/88391


More information about the Mlir-commits mailing list