[Mlir-commits] [mlir] [mlir][transform] Add support for transform.param pad multiples in `PadOp` (PR #90755)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 1 18:33:03 PDT 2024


================
@@ -1021,8 +1023,7 @@ def PadOp : Op<Transform_Dialect, "structured.pad",
                       TransformHandleTypeInterface:$pad,
                       TransformHandleTypeInterface:$copy);
 
-  let assemblyFormat =
-    "$target attr-dict `:` functional-type(operands, results)";
+  let hasCustomAssemblyFormat = 1;
----------------
srcarroll wrote:

actually i remember now. using the available directives would result in having the param/handle types inlined into the list they are passed to, e.g.
```
    %1:2 = transform.structured.tile_using_forall %0 tile_sizes [%sz : !transform.any_op, 20]
           : (!transform.any_op) -> (!transform.any_op, !transform.any_op)
```
opposed to
```
    %1:2 = transform.structured.tile_using_forall %0 tile_sizes [%sz, 20]
           : (!transform.any_op, !transform.any_op) -> (!transform.any_op, !transform.any_op)
```
like how `tile_using_for` does it. i prefered the latter and followed it for both the pad and vectorize op

https://github.com/llvm/llvm-project/pull/90755


More information about the Mlir-commits mailing list