[Mlir-commits] [mlir] a0c019a - [mlir][linalg] Delete unused SameVariadicOperandSize trait from ops (#87124)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sun Mar 31 14:35:58 PDT 2024


Author: Philip Lassen
Date: 2024-03-31T23:35:55+02:00
New Revision: a0c019ae9ebd507bf7df58f6cc13eb7ebcd5e97f

URL: https://github.com/llvm/llvm-project/commit/a0c019ae9ebd507bf7df58f6cc13eb7ebcd5e97f
DIFF: https://github.com/llvm/llvm-project/commit/a0c019ae9ebd507bf7df58f6cc13eb7ebcd5e97f.diff

LOG: [mlir][linalg] Delete unused SameVariadicOperandSize trait from ops (#87124)

Both `Transpose` and `Broadcast` specify the `SameVariadicOperandSize`
trait. However neither has a variadic operand let alone more than one.

This is likely a relic from copying the boilerplate of the `Reduce`
definition.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
index 92d844eefb7207..5ee363ed325727 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
@@ -391,7 +391,6 @@ def ReduceOp : LinalgStructuredBase_Op<"reduce", [
 
 def TransposeOp : LinalgStructuredBase_Op<"transpose", [
     DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
-    SameVariadicOperandSize,
     SingleBlockImplicitTerminator<"YieldOp">]> {
   let summary = "Transpose operator";
   let description = [{
@@ -470,7 +469,6 @@ def TransposeOp : LinalgStructuredBase_Op<"transpose", [
 
 def BroadcastOp : LinalgStructuredBase_Op<"broadcast", [
     DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
-    SameVariadicOperandSize,
     SingleBlockImplicitTerminator<"YieldOp">]> {
   let summary = "Static broadcast operator";
   let description = [{


        


More information about the Mlir-commits mailing list