[Mlir-commits] [mlir] [mlir] Add `convertInstruction` and `getSupportedInstructions` to `LLVMImportInterface` (PR #86799)

Christian Ulmann llvmlistbot at llvm.org
Wed Mar 27 07:05:33 PDT 2024


================
@@ -123,12 +123,16 @@ static SmallVector<int64_t> getPositionFromIndices(ArrayRef<unsigned> indices) {
 /// access to the private module import methods.
 static LogicalResult convertInstructionImpl(OpBuilder &odsBuilder,
                                             llvm::Instruction *inst,
-                                            ModuleImport &moduleImport) {
+                                            ModuleImport &moduleImport,
+                                            LLVMImportInterface &importIface) {
----------------
Dinistro wrote:

Ultra nit: `iface` might be good enough for a name. All other places use `iface` as a name for variables of the type `LLVMImportInterface`. 

https://github.com/llvm/llvm-project/pull/86799


More information about the Mlir-commits mailing list