[Mlir-commits] [mlir] [mlir] Add `requiresVisitingMutatedDefs` and `visitMutatedDefs` to `PromotableOpInterface` (PR #86792)

Christian Ulmann llvmlistbot at llvm.org
Wed Mar 27 06:27:09 PDT 2024


https://github.com/Dinistro commented:

I do not see how this is equivalent to the existing implementation.

If I understand correctly, this change will pass all N changed definitions to each visitor-function, instead of running the visitor for each `DbgValueOp` separately.

Maybe add a test with two dbg value ops on the same store to determine that this works as intended.

https://github.com/llvm/llvm-project/pull/86792


More information about the Mlir-commits mailing list