[Mlir-commits] [mlir] [mlir][test] Make SME e2e tests require an emulator (PR #86489)

Cullen Rhodes llvmlistbot at llvm.org
Wed Mar 27 03:21:07 PDT 2024


c-rhodes wrote:

> > I would think it's pretty obvious an emulator is required when a user hits SIGILLs when trying to run the tests
> 
> This change is trying to help folks for whom it would be less obvious :) And even for experts, a meaningful CMake error saying "you need to set-up _this_ CMake variable" would be more informative compared to what we get today.

Apologies, that wasn't constructive. I can see the improvement you're trying to make and agree it's better to be pointed in the right direction. I'm just not sure about the current approach.

https://github.com/llvm/llvm-project/pull/86489


More information about the Mlir-commits mailing list